>
> - @ConstructorProperties({ "kind", "nextPageToken", "items" })
> - protected ListPage(Kind kind, String nextPageToken, Iterable<T> items) {
> - this.kind = checkNotNull(kind, "kind");
> - this.nextPageToken = nextPageToken;
> - this.items = items != null ? ImmutableList.copyOf(items) :
> ImmutableList.<T>of();
> + public ListPage(PageWithMarker<T> delegate, Function<PageWithMarker<T>,
> PagedIterable<T>> advancingFunction) {
In fact, I first implemented it by returning a regular `IterableWithMarker`
(the usual approach without references to the advancing function in the
iterable itself), but I when I started modifying the live and expect tests I
decided to change that, as I found it really ugly to keep the current tests
with the new approach. All rely in the PagedIterable even when getting one
page, and the code turned non-readable when having to manually get the
advancing function.
Anyway, I'm OK to change to that approach, but I'll also refactor the majority
of the tests. Most of the expect tests are a mess, and live tests that use
lists have a lot of improvement, so I'll change them and refactor all expect
tests to MWS ones.
It will take some more time, but we'll have a cleaner provider and the tests in
the way we want them :)
Thanks for the feedback!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/62/files#r19332948
