Private injection requires reflection and limits DI choices. Binders don't need to check null as jclouds already checks null for any param not marked nullable. You can merge this Pull Request by running:
git pull https://github.com/adriancole/jclouds-labs-google adrian.cleanup-binders Or you can view, comment on it, or merge it online at: https://github.com/jclouds/jclouds-labs-google/pull/64 -- Commit Summary -- * Cleanup binders in GCE: don't use sneaky injection. don't redundantly check null. -- File Changes -- R google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/binders/DiskCreationBinder.java (23) R google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/binders/FirewallBinder.java (33) R google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/binders/GoogleComputeEngineErrorHandler.java (5) R google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/binders/InstanceBinder.java (32) R google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/binders/MetadataBinder.java (35) R google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/binders/RouteBinder.java (33) M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/config/GoogleComputeEngineHttpApiModule.java (2) M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/features/DiskApi.java (2) M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/features/FirewallApi.java (2) M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/features/InstanceApi.java (4) M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/features/ProjectApi.java (2) M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/features/RouteApi.java (2) R google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/binders/DiskCreationBinderTest.java (2) R google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/binders/GoogleComputeEngineErrorHandlerTest.java (2) -- Patch Links -- https://github.com/jclouds/jclouds-labs-google/pull/64.patch https://github.com/jclouds/jclouds-labs-google/pull/64.diff --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/64
