Overhead of LinkedHashSet/Map is vs not is inconsequential. When porting production code to not break tests across JRE 7 and 8 at square, we wild-carded this change after peer review. It is safe. You can merge this Pull Request by running:
git pull https://github.com/adriancole/jclouds-labs-google adrian.iteration-order Or you can view, comment on it, or merge it online at: https://github.com/jclouds/jclouds-labs-google/pull/66 -- Commit Summary -- * Iteration order of HashSet/Map changes between JRE 7 and JRE 8, breaking tests. Switch to LinkedHashSet/Map. -- File Changes -- M google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/blobstore/strategy/internal/SequentialMultipartUploadStrategy.java (2) M google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/domain/templates/BucketTemplate.java (6) M google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/domain/templates/ComposeObjectTemplate.java (2) M google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/domain/templates/ObjectTemplate.java (4) M google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/blobstore/integration/GCSBlobIntegrationLiveTest.java (2) M google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/blobstore/integration/GCSContainerIntegrationLiveTest.java (2) M google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/features/ObjectApiLiveTest.java (6) M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/compute/GoogleComputeEngineService.java (2) M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/compute/strategy/CreateNodesWithGroupEncodedIntoNameThenAddToSet.java (2) -- Patch Links -- https://github.com/jclouds/jclouds-labs-google/pull/66.patch https://github.com/jclouds/jclouds-labs-google/pull/66.diff --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/66
