>     }
>  
>     @Override
>     public Map<String, Supplier<URI>> get() {
> -      Builder<String, Supplier<URI>> builder = ImmutableMap.<String, 
> Supplier<URI>> builder();
> -      for (Entry<String, Supplier<URI>> regionToURI : 
> regionIdToURISupplier.get().entrySet()) {
> -         for (String zone : 
> regionIdToZoneIdsSupplier.get().get(regionToURI.getKey()).get()) {
> +      Map<String, Supplier<Set<String>>> regionIdToZoneIds = 
> this.regionIdToZoneIds.get();
> +      Builder<String, Supplier<URI>> builder = ImmutableMap.builder();
> +      for (Entry<String, Supplier<URI>> regionToURI : 
> regionIdToURIs.get().entrySet()) {
> +         Supplier<Set<String>> zoneIds = 
> regionIdToZoneIds.get(regionToURI.getKey());
> +         checkState(zoneIds != null, "region %s is not in the configured 
> region to zone mappings: %s",
> +               regionToURI.getKey(), regionIdToZoneIds);

yeah I don't like saying the same thing twice. iotw 
`regionIdToZoneIds.containsKey(regionToURI.getKey())` is a mouthful, as is 
`regionIdToZoneIds.get(regionToURI.getKey())`

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/602/files#r20411991

Reply via email to