When we add a `@Fallback`, we absolutely need a test to make sure we put the right one there. However, if we don't add a fallback annotation, we don't need to test error responses. When we do, we are only partially covering the universe of potential errors, and drowning out tests that are actually api-specific. Since it is less work anyway, I'm sure removing these will be welcome! You can merge this Pull Request by running:
git pull https://github.com/adriancole/jclouds-labs-google adrian.dont-test-defaults Or you can view, comment on it, or merge it online at: https://github.com/jclouds/jclouds-labs-google/pull/94 -- Commit Summary -- * Remove tests for default fallbacks. This helps clarify code towards what's GCE-specific. -- File Changes -- M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/DiskApiExpectTest.java (27) M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/HttpHealthCheckApiExpectTest.java (66) M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/ImageApiExpectTest.java (20) M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/InstanceApiExpectTest.java (99) M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/TargetPoolApiExpectTest.java (63) -- Patch Links -- https://github.com/jclouds/jclouds-labs-google/pull/94.patch https://github.com/jclouds/jclouds-labs-google/pull/94.diff --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/94
