OAuth smoke and mirror indirection is coming to an end. Through tracing code, I've found that we only actually issue Bearer tokens. I've renamed accordingly, and flattened a complex cache mapping. There's at least one more cleanup round to do, but this should be the last api-breaker
TODO for implementors (aka @ccustine) * Use OAuthModule, not OAuthAuthenticationModule * Use OAuthFilter, not OAuthAuthenticationFilter * else is the same Details. * Refactor OAuth to be less complex. * Remove OAuth as a registered api. * Rename redundant OAuthAuthenticationFilter to OAuthFilter. You can merge this Pull Request by running: git pull https://github.com/adriancole/jclouds-labs-google adrian.oauth-cleanup-again Or you can view, comment on it, or merge it online at: https://github.com/jclouds/jclouds-labs-google/pull/96 -- Commit Summary -- * Refactor OAuth to be less complex. Remove oauth as a standalone api. Rename redundant OAuthAuthenticationFilter to OAuthFilter. -- File Changes -- M google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/GoogleCloudStorageApiMetadata.java (2) M google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/features/BucketAccessControlsApi.java (4) M google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/features/BucketApi.java (4) M google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/features/DefaultObjectAccessControlsApi.java (4) M google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/features/ObjectAccessControlsApi.java (4) M google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/features/ObjectApi.java (4) M google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/features/ResumableUploadApi.java (4) M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/GoogleComputeEngineApiMetadata.java (2) M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/compute/functions/Resources.java (4) M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/config/GoogleComputeEngineHttpApiModule.java (4) M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/features/AddressApi.java (4) M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/features/AggregatedListApi.java (4) M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/features/DiskApi.java (4) M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/features/DiskTypeApi.java (4) M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/features/FirewallApi.java (4) M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/features/ForwardingRuleApi.java (4) M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/features/HttpHealthCheckApi.java (4) M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/features/ImageApi.java (4) M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/features/InstanceApi.java (4) M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/features/MachineTypeApi.java (4) M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/features/NetworkApi.java (4) M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/features/OperationApi.java (4) M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/features/ProjectApi.java (4) M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/features/RegionApi.java (4) M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/features/RouteApi.java (4) M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/features/SnapshotApi.java (4) M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/features/TargetPoolApi.java (4) M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/features/ZoneApi.java (4) M oauth/pom.xml (1) R oauth/src/main/java/org/jclouds/oauth/v2/AuthorizationApi.java (37) D oauth/src/main/java/org/jclouds/oauth/v2/OAuthApi.java (61) D oauth/src/main/java/org/jclouds/oauth/v2/OAuthApiMetadata.java (83) R oauth/src/main/java/org/jclouds/oauth/v2/config/Authorization.java (6) D oauth/src/main/java/org/jclouds/oauth/v2/config/OAuthAuthenticationModule.java (46) D oauth/src/main/java/org/jclouds/oauth/v2/config/OAuthHttpApiModule.java (42) M oauth/src/main/java/org/jclouds/oauth/v2/config/OAuthModule.java (48) R oauth/src/main/java/org/jclouds/oauth/v2/filters/BearerTokenFromCredentials.java (8) A oauth/src/main/java/org/jclouds/oauth/v2/filters/DynamicBearerToken.java (74) D oauth/src/main/java/org/jclouds/oauth/v2/filters/OAuthAuthenticator.java (51) R oauth/src/main/java/org/jclouds/oauth/v2/filters/OAuthFilter.java (2) M oauth/src/main/java/org/jclouds/oauth/v2/functions/PrivateKeySupplier.java (2) M oauth/src/main/java/org/jclouds/oauth/v2/functions/SignOrProduceMacForToken.java (4) D oauth/src/main/java/org/jclouds/oauth/v2/handlers/OAuthErrorHandler.java (58) A oauth/src/test/java/org/jclouds/oauth/v2/AuthorizationApiLiveTest.java (102) R oauth/src/test/java/org/jclouds/oauth/v2/AuthorizationApiMockTest.java (31) D oauth/src/test/java/org/jclouds/oauth/v2/OAuthApiMetadataTest.java (39) D oauth/src/test/java/org/jclouds/oauth/v2/features/OAuthApiLiveTest.java (84) D oauth/src/test/java/org/jclouds/oauth/v2/handlers/OAuthErrorHandlerTest.java (92) D oauth/src/test/java/org/jclouds/oauth/v2/internal/Base64UrlSafeTest.java (40) D oauth/src/test/java/org/jclouds/oauth/v2/internal/BaseOAuthApiLiveTest.java (63) D oauth/src/test/java/org/jclouds/oauth/v2/internal/BaseOAuthAuthenticatedApiLiveTest.java (112) -- Patch Links -- https://github.com/jclouds/jclouds-labs-google/pull/96.patch https://github.com/jclouds/jclouds-labs-google/pull/96.diff --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/96
