This adds coverage of TargetPoolApi:AggregatedList and TargetPoolApi:GetHealth. 

Also updates HttpHealthChecks. Defaults were not being set in HttpHealthChecks. 
This was hidden by the fact that we assumed default values when nothing was 
returned in the request. This PR addresses this and changes 
HttpHealthCheckCreationOptions to enable making a request with or without the 
default values. 

Also converts TargetPoolApi to mock test. 
You can merge this Pull Request by running:

  git pull https://github.com/GoogleCloudPlatform/jclouds-labs-google 
targetPoolUpdate

Or you can view, comment on it, or merge it online at:

  https://github.com/jclouds/jclouds-labs-google/pull/105

-- Commit Summary --

  * Added targetPool:AggregatedList, getHealth. Updated HttpHealthCheck

-- File Changes --

    M 
google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/binders/HttpHealthCheckCreationBinder.java
 (4)
    R 
google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/domain/HealthStatus.java
 (18)
    M 
google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/domain/HttpHealthCheck.java
 (24)
    M 
google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/features/AggregatedListApi.java
 (51)
    M 
google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/features/BackendServiceApi.java
 (4)
    M 
google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/features/HttpHealthCheckApi.java
 (2)
    M 
google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/features/TargetPoolApi.java
 (17)
    M 
google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/options/HttpHealthCheckCreationOptions.java
 (280)
    M 
google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/binders/HttpHealthCheckCreationBinderTest.java
 (16)
    M 
google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/AggregatedListApiLiveTest.java
 (18)
    M 
google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/AggregatedListApiMockTest.java
 (34)
    M 
google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/BackendServiceApiMockTest.java
 (6)
    M 
google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/HttpHealthCheckApiExpectTest.java
 (4)
    M 
google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/HttpHealthCheckApiLiveTest.java
 (43)
    M 
google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/HttpHealthCheckApiMockTest.java
 (8)
    D 
google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/TargetPoolApiExpectTest.java
 (263)
    M 
google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/TargetPoolApiLiveTest.java
 (73)
    A 
google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/TargetPoolApiMockTest.java
 (178)
    R 
google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseHealthStatusTest.java
 (18)
    M 
google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseTargetPoolListTest.java
 (7)
    M 
google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseTargetPoolTest.java
 (9)
    A google-compute-engine/src/test/resources/aggregated_target_pool_list.json 
(46)
    A 
google-compute-engine/src/test/resources/aggregated_target_pool_list_empty.json 
(43)
    R google-compute-engine/src/test/resources/health_status_get_health.json (2)
    M google-compute-engine/src/test/resources/httphealthcheck_insert.json (2)
    A google-compute-engine/src/test/resources/httphealthcheck_patch.json (1)

-- Patch Links --

https://github.com/jclouds/jclouds-labs-google/pull/105.patch
https://github.com/jclouds/jclouds-labs-google/pull/105.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/105

Reply via email to