Thanks @cdancy! This is a great starting PR. Code looks pretty good!
Once the initial comments are addressed, and before being able to merge it, 
unit tests must be added:

* MockWebserver tests for each Api method.
* Unit tests for the Authentication filter.
* Unit tests for the custom fallback class, if we keep it.

You can take a look at GCE or digital ocean for examples of MWS tests. For 
other unit tests you can just create what you need, or use EasyMock. Let us 
know if you need help!

Please, don't squash the changes until the PR is about to merge, at it is much 
easier to review just the new commits than going through the entire PR again :)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/116#issuecomment-67080637

Reply via email to