>     private final TrustManager[] trustManager;
>     private final Supplier<Credentials> creds;
>  
>     @Inject
> -   SSLContextWithKeysSupplier(Supplier<KeyStore> keyStore, @Provider 
> Supplier<Credentials> creds, HttpUtils utils,
> -         TrustAllCerts trustAllCerts) {
> -      this.keyStore = keyStore;
> -      this.trustManager = utils.trustAllCerts() ? new TrustManager[] { 
> trustAllCerts } : null;
> +   SSLContextWithKeysSupplier(@Provider Supplier<Credentials> creds, 
> TrustAllCerts trustAllCerts) {
> +      this.trustManager = new TrustManager[]{trustAllCerts};

Are you going to *always* trust all certs? That should be configured by users 
when setting the corresponding properties when creating the context. You should 
check the `utils.trustAllCerts()` value and act accordingly.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/113/files#r21864915

Reply via email to