Currently the options classes are not consistent.

This PR modifies `TargetHttpProxyOptions` and `TargetPoolCreationOptions`. 
Are these improvements and should other Options classes be changed to this form?
You can merge this Pull Request by running:

  git pull https://github.com/GoogleCloudPlatform/jclouds-labs-google 
optionsCleanup

Or you can view, comment on it, or merge it online at:

  https://github.com/jclouds/jclouds-labs-google/pull/117

-- Commit Summary --

  * Updated targetHttpProxyOptions to AutoValue + Builder
  * Updated TargetPoolCreationOptions to AutoValue + Builder

-- File Changes --

    D 
google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/binders/TargetPoolCreationBinder.java
 (75)
    M 
google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/features/TargetHttpProxyApi.java
 (1)
    M 
google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/features/TargetPoolApi.java
 (5)
    M 
google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/options/TargetHttpProxyOptions.java
 (76)
    M 
google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/options/TargetPoolCreationOptions.java
 (195)
    D 
google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/binders/TargetPoolCreationBinderTest.java
 (72)
    M 
google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/ForwardingRuleApiLiveTest.java
 (7)
    M 
google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/TargetHttpProxyApiMockTest.java
 (15)
    M 
google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/TargetPoolApiLiveTest.java
 (19)
    M 
google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/TargetPoolApiMockTest.java
 (4)
    M google-compute-engine/src/test/resources/target_http_proxy_insert.json (5)

-- Patch Links --

https://github.com/jclouds/jclouds-labs-google/pull/117.patch
https://github.com/jclouds/jclouds-labs-google/pull/117.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/117

Reply via email to