> + .status(Image.Status.AVAILABLE)
> + .uri(image.mediaLink())
> + .providerId(image.publisherName())
> + .location(createLocation(image.location()));
> +
> + OperatingSystem.Builder osBuilder = setOperatingSystem(image);
> + return builder.operatingSystem(osBuilder.build()).build();
> + }
> +
> + private OperatingSystem.Builder setOperatingSystem(OSImage image) {
> + OsFamily family = osFamily().apply(image.label());
> + String version = version().apply(image.label());
> + if (family != OsFamily.UNRECOGNIZED) {
> + return OperatingSystem.builder().family(family).version(version)
> + .description(image.description());
> + } else if (family == OsFamily.UNRECOGNIZED && image.os() ==
> OSImage.Type.WINDOWS) {
I really think this logic should be part of `osFamily().apply()` maybe changing
it into `osFamily().apply(osImage)` ?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/117/files#r22148131
