> + return OsFamily.WINDOWS;
> + else if (label.toUpperCase().contains("ORACLE LINUX"))
> + return OsFamily.OEL;
> + }
> + return OsFamily.UNRECOGNIZED;
> + }
> + };
> + }
> +
> + public static Function<String, String> version() {
> + return new Function<String, String>() {
> + @Override
> + public String apply(final String label) {
> + if (label != null) {
> + //ex: CoreOS Alpha -> Alpha
> + if (label.toUpperCase().contains("COREOS"))
These checks don't seem to be consistent. You perform a "case insensitive"
check , but then a "case sensitive" replacement. This doesn't seem to be
properly handled.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/117/files#r22192182
