This removes the SecurityGroupExtension from Google Compute Engine. The current implementation does match what is expected from that extension. In GCE, firewall rules are applied to a particular network, and there is no notion of *global* security groups.
The current implementation maps a security group to a network, and then applies the rules to that network, but that is not appropriate. The number of networks that can be created is limited, and managing the security groups could end up exhausting the networks, making it not possible to create new instances. The way GCE works don't fit in the security group extension, and it should be better removed. A FirewallExtesion or similar would make sense if there are other providers that work in a similar way. /cc @danbroudy @andreaturli You can merge this Pull Request by running: git pull https://github.com/nacx/jclouds-labs-google sg-extension Or you can view, comment on it, or merge it online at: https://github.com/jclouds/jclouds-labs-google/pull/119 -- Commit Summary -- * Removed the SecurityGroupExtension -- File Changes -- M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/compute/config/GoogleComputeEngineServiceContextModule.java (16) D google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/compute/extensions/GoogleComputeEngineSecurityGroupExtension.java (334) D google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/compute/functions/FirewallToIpPermission.java (67) D google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/compute/functions/NetworkToSecurityGroup.java (67) D google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/compute/predicates/NetworkFirewallPredicates.java (125) D google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/compute/extensions/GoogleComputeEngineSecurityGroupExtensionLiveTest.java (35) D google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/compute/functions/FirewallToIpPermissionTest.java (93) D google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/compute/functions/NetworkToSecurityGroupTest.java (85) D google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/predicates/NetworkFirewallPredicatesTest.java (162) -- Patch Links -- https://github.com/jclouds/jclouds-labs-google/pull/119.patch https://github.com/jclouds/jclouds-labs-google/pull/119.diff --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/119
