> +   VirtualMachineToNodeMetadata(@Memoized Supplier<Set<? extends Image>> 
> images, @Memoized Supplier<Set<? extends Hardware>> hardwares,
> +                                Supplier<Set<? extends Location>> locations,
> +                                GroupNamingConvention.Factory 
> namingConvention,
> +                                Map<DeploymentStatus, Status> 
> deploymentStatusToStatus, Map<String, Status> instanceStatusToStatus) {
> +      this.nodeNamingConvention = checkNotNull(namingConvention, 
> "namingConvention").createWithoutPrefix();
> +      this.images = checkNotNull(images, "images");
> +      this.hardwares = checkNotNull(hardwares, "hardwares");
> +      this.locations = checkNotNull(locations, "locations");
> +      this.deploymentStatusToStatus = checkNotNull(deploymentStatusToStatus);
> +      this.instanceStatusToStatus = instanceStatusToStatus;
> +   }
> +
> +   @Override
> +   public NodeMetadata apply(VirtualMachine from) {
> +      NodeMetadataBuilder builder = new NodeMetadataBuilder();
> +      builder.ids(from.getServiceName() + ":" + from.getRoleName());

Same comment about the image IDs. You might want to set separately the `id` and 
the `providerId`.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/132/files#r24748608

Reply via email to