Hi! This PR implements ProfitBricks' 
[NIC](https://www.profitbricks.com/apidoc/1_3/APIDocumentation.html?NICOperations.html)
 and 
[Firewall](https://www.profitbricks.com/apidoc/1_3/APIDocumentation.html?FirewallOperations.html)
 APIs. Looking forward to the code review to correct stuff I might've missed. :)


/cc @nacx @jasminSPC
You can view, comment on, or merge this pull request online at:

  https://github.com/jclouds/jclouds-labs/pull/139

-- Commit Summary --

  * JCLOUDS-702: JCloud ProfitBricks provider - NIC & Firewall API

-- File Changes --

    M profitbricks/src/main/java/org/jclouds/profitbricks/ProfitBricksApi.java 
(8)
    A 
profitbricks/src/main/java/org/jclouds/profitbricks/binder/firewall/AddFirewallRuleToNicRequestBinder.java
 (53)
    A 
profitbricks/src/main/java/org/jclouds/profitbricks/binder/firewall/FirewallBinder.java
 (95)
    A 
profitbricks/src/main/java/org/jclouds/profitbricks/binder/nic/CreateNicRequestBinder.java
 (46)
    A 
profitbricks/src/main/java/org/jclouds/profitbricks/binder/nic/SetInternetAccessBinder.java
 (42)
    A 
profitbricks/src/main/java/org/jclouds/profitbricks/binder/nic/UpdateNicRequestBinder.java
 (46)
    M 
profitbricks/src/main/java/org/jclouds/profitbricks/compute/internal/ProvisioningStatusAware.java
 (2)
    M 
profitbricks/src/main/java/org/jclouds/profitbricks/compute/internal/ProvisioningStatusPollingPredicate.java
 (7)
    A profitbricks/src/main/java/org/jclouds/profitbricks/domain/Firewall.java 
(367)
    A profitbricks/src/main/java/org/jclouds/profitbricks/domain/Nic.java (379)
    M profitbricks/src/main/java/org/jclouds/profitbricks/domain/Server.java 
(427)
    M profitbricks/src/main/java/org/jclouds/profitbricks/domain/Storage.java 
(1)
    A 
profitbricks/src/main/java/org/jclouds/profitbricks/domain/internal/FirewallRuleCommonProperties.java
 (44)
    M 
profitbricks/src/main/java/org/jclouds/profitbricks/features/DataCenterApi.java 
(12)
    A 
profitbricks/src/main/java/org/jclouds/profitbricks/features/FirewallApi.java 
(93)
    A profitbricks/src/main/java/org/jclouds/profitbricks/features/NicApi.java 
(84)
    M 
profitbricks/src/main/java/org/jclouds/profitbricks/features/ServerApi.java (20)
    M 
profitbricks/src/main/java/org/jclouds/profitbricks/features/StorageApi.java 
(11)
    M 
profitbricks/src/main/java/org/jclouds/profitbricks/http/ResponseStatusFromPayloadHttpCommandExecutorService.java
 (76)
    M 
profitbricks/src/main/java/org/jclouds/profitbricks/http/parser/BaseProfitBricksResponseHandler.java
 (4)
    M 
profitbricks/src/main/java/org/jclouds/profitbricks/http/parser/datacenter/DataCenterInfoResponseHandler.java
 (78)
    A 
profitbricks/src/main/java/org/jclouds/profitbricks/http/parser/firewall/BaseFirewallResponseHandler.java
 (69)
    A 
profitbricks/src/main/java/org/jclouds/profitbricks/http/parser/firewall/FirewallListResponseHandler.java
 (64)
    A 
profitbricks/src/main/java/org/jclouds/profitbricks/http/parser/firewall/FirewallResponseHandler.java
 (63)
    A 
profitbricks/src/main/java/org/jclouds/profitbricks/http/parser/firewall/rule/BaseFirewallRuleResponseHandler.java
 (54)
    A 
profitbricks/src/main/java/org/jclouds/profitbricks/http/parser/firewall/rule/FirewallRuleListResponseHandler.java
 (54)
    A 
profitbricks/src/main/java/org/jclouds/profitbricks/http/parser/nic/BaseNicResponseHandler.java
 (82)
    A 
profitbricks/src/main/java/org/jclouds/profitbricks/http/parser/nic/NicListResponseHandler.java
 (65)
    A 
profitbricks/src/main/java/org/jclouds/profitbricks/http/parser/nic/NicResponseHandler.java
 (58)
    M 
profitbricks/src/main/java/org/jclouds/profitbricks/http/parser/server/BaseServerResponseHandler.java
 (74)
    M 
profitbricks/src/main/java/org/jclouds/profitbricks/http/parser/server/ServerInfoResponseHandler.java
 (34)
    M 
profitbricks/src/main/java/org/jclouds/profitbricks/http/parser/server/ServerListResponseHandler.java
 (44)
    M 
profitbricks/src/main/java/org/jclouds/profitbricks/http/parser/storage/BaseStorageResponseHandler.java
 (20)
    M 
profitbricks/src/main/java/org/jclouds/profitbricks/http/parser/storage/StorageListResponseHandler.java
 (19)
    A profitbricks/src/main/java/org/jclouds/profitbricks/util/Strings3.java 
(43)
    A 
profitbricks/src/test/java/org/jclouds/profitbricks/binder/firewall/AddFirewallRuleToNicRequestBinderTest.java
 (64)
    A 
profitbricks/src/test/java/org/jclouds/profitbricks/binder/firewall/FirewallBinderTest.java
 (131)
    A 
profitbricks/src/test/java/org/jclouds/profitbricks/binder/nic/CreateNicRequestBinderTest.java
 (53)
    A 
profitbricks/src/test/java/org/jclouds/profitbricks/binder/nic/SetInternetAccessBinderTest.java
 (48)
    A 
profitbricks/src/test/java/org/jclouds/profitbricks/binder/nic/UpdateNicRequestBinderTest.java
 (54)
    A 
profitbricks/src/test/java/org/jclouds/profitbricks/domain/FirewallRuleBuilderTest.java
 (82)
    A 
profitbricks/src/test/java/org/jclouds/profitbricks/features/FirewallApiLiveTest.java
 (146)
    A 
profitbricks/src/test/java/org/jclouds/profitbricks/features/FirewallApiMockTest.java
 (324)
    A 
profitbricks/src/test/java/org/jclouds/profitbricks/features/NicApiLiveTest.java
 (136)
    A 
profitbricks/src/test/java/org/jclouds/profitbricks/features/NicApiMockTest.java
 (222)
    M 
profitbricks/src/test/java/org/jclouds/profitbricks/http/parser/datacenter/DataCenterInfoResponseHandlerTest.java
 (114)
    A 
profitbricks/src/test/java/org/jclouds/profitbricks/http/parser/firewall/FirewallListResponseHandlerTest.java
 (87)
    A 
profitbricks/src/test/java/org/jclouds/profitbricks/http/parser/firewall/FirewallResponseHandlerTest.java
 (71)
    A 
profitbricks/src/test/java/org/jclouds/profitbricks/http/parser/nic/NicListResponseHandlerTest.java
 (95)
    A 
profitbricks/src/test/java/org/jclouds/profitbricks/http/parser/nic/NicResponseHandlerTest.java
 (66)
    M 
profitbricks/src/test/java/org/jclouds/profitbricks/http/parser/server/ServerInfoResponseHandlerTest.java
 (72)
    M 
profitbricks/src/test/java/org/jclouds/profitbricks/http/parser/server/ServerListResponseHandlerTest.java
 (147)
    M profitbricks/src/test/resources/datacenter/datacenter.xml (3)
    A profitbricks/src/test/resources/firewall/firewall-activate.xml (12)
    A profitbricks/src/test/resources/firewall/firewall-addtonic.xml (23)
    A profitbricks/src/test/resources/firewall/firewall-deactivate.xml (12)
    A profitbricks/src/test/resources/firewall/firewall-delete.xml (12)
    A profitbricks/src/test/resources/firewall/firewall-remove.xml (12)
    A profitbricks/src/test/resources/firewall/firewall.xml (23)
    A profitbricks/src/test/resources/firewall/firewalls.xml (39)
    A profitbricks/src/test/resources/nic/nic-create.xml (13)
    A profitbricks/src/test/resources/nic/nic-delete.xml (9)
    A profitbricks/src/test/resources/nic/nic-internetaccess.xml (11)
    A profitbricks/src/test/resources/nic/nic-update.xml (15)
    A profitbricks/src/test/resources/nic/nic.xml (27)
    A profitbricks/src/test/resources/nic/nics.xml (49)
    M profitbricks/src/test/resources/server/servers.xml (1)

-- Patch Links --

https://github.com/jclouds/jclouds-labs/pull/139.patch
https://github.com/jclouds/jclouds-labs/pull/139.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/139

Reply via email to