As far as adding a new test for the fallback does it make sense to create a separate class or add the test functionality elsewhere? The refactor of the fallbacks is going to leave me with a class 'BooleanOnServiceKeyNotFoundAnd500' which is already going to be exercised as part of ShipyardKeysApiMockTest.testDeleteNonExistentServiceKey. I've got a tester here named 'testDeleteNonExistentServiceKeyWithErroneousBody' which will stress the aforementioned fallback to ensure it throws an exception should all checks not succeed. I guess my ultimate question is: should I put that tester in its own class, say ShipyardFallbacksTest, or append it to ServiceKeysApiMockTest? I can see reasons for both and am not married to either.
--- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/149#issuecomment-78471209
