[
https://issues.apache.org/jira/browse/JCLOUDS-849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14377619#comment-14377619
]
fabio martelli edited comment on JCLOUDS-849 at 3/24/15 10:40 AM:
------------------------------------------------------------------
Hi Ignasi, thank you for your prompt reply.
Yes, you are right, I won't be able to change into DeploymentAPI. Sorry for the
mistake.
I have taken a look into AzureComputeServiceAdapter about listNodes() and
getNodes(). I could perform my changes into this class but I think that this
won't be enogh since missing location comes from a deployment creation.
Furthermore, I do think that this change will be in conflict with [~Bhash90]
proposal (see JCLOUDS-853) so it would result in a waste of time.
Since you agree with the option 1, I will retrieve the CloudService information
in the transformation function.
Thank you again for your very good support.
was (Author: fmartelli):
Hi Ignasi, thank you for your prompt reply.
Yes, you are right, I won't be able to change into DeploymentAPI. Sorry for the
mistake.
I have taken a look into AzureComputeServiceAdapter about listNodes() and
getNodes(). I could perform my changes into this class but I think that this
won't be enogh since missing location comes from a deployment creation.
Furthermore, I do think that this change will be in conflict with [~Bhash90]
proposal (see JCLOUDS-853) so it would result in a waste of time.
Since you seems agree with the option 1, I will retrieve the CloudService
information in the transformation function.
Thank you again for your very good support.
> Add the live test that extends the BaseComputeServiceLiveTest
> -------------------------------------------------------------
>
> Key: JCLOUDS-849
> URL: https://issues.apache.org/jira/browse/JCLOUDS-849
> Project: jclouds
> Issue Type: Sub-task
> Components: jclouds-compute, jclouds-labs
> Reporter: Ignasi Barrera
> Assignee: fabio martelli
> Labels: azure
> Fix For: 2.0.0
>
>
> The BaseComputeServiceLiveTest provides the contract of the ComputeService
> abstraction. All compute providers must have a test that extends the base one
> with all live tests passing.
> An example implemention can be the DigitalOcean one:
> https://github.com/jclouds/jclouds-labs/blob/master/digitalocean/src/main/java/org/jclouds/digitalocean/compute/strategy/DigitalOceanComputeServiceAdapter.java
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
