> @@ -81,34 +83,44 @@ private Location createLocation(final String input) {
>        if (input == null) {
>           return null;
>        }
> -      return new LocationBuilder().
> -              id(input).
> -              scope(LocationScope.REGION).
> -              description(input).
> -              parent(Iterables.getOnlyElement(provider.get())).
> -              metadata(ImmutableMap.<String, Object>of("name", input)).
> -              build();
> +
> +      final LocationBuilder builder = new LocationBuilder();

Instead of manually creating a location here, you'd better inject the location 
supplier into this class and pick one of the existing locations.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/156/files#r27518879

Reply via email to