>                .toString();
>     }
>  
>     public static final DockerTemplateOptions NONE = new 
> DockerTemplateOptions();
>  
>     public DockerTemplateOptions volumes(Map<String, String> volumes) {
> -      this.volumes = Optional.<Map<String, String>> 
> of(ImmutableMap.copyOf(volumes));
> +      for (Map.Entry<String, String> entry : checkNotNull(volumes, 
> "volumes").entrySet()) {
> +         checkNotNull(entry.getKey(), "host paths must not be null");
> +         checkNotNull(entry.getValue(), "container paths must not be null");
> +      }

I couldn't remember. So, do you think we get a useful enogh error when we 
create an `ImmutableMap` from a `HashMap` with nulls in it? If so, we just need 
the `checkNotNull(input)` type validation, and I'll update the PR 
appropriately. _**Checked** and it does a `checkEntryNotNull` so we're all good_

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/162/files#r27838342

Reply via email to