https://issues.apache.org/jira/browse/JCLOUDS-876

@ilgrosso I opted to add your code snippet to the `copyTo` method. The other 
approach looked cleaner, but initialising the options presented some issues 
[here](https://github.com/jclouds/jclouds/blob/master/compute/src/main/java/org/jclouds/compute/internal/BaseComputeService.java#L697-L710):
 the ComputeService overrides the node credentials if the user provided them in 
the template options, but if we initialise them to absent, there is no clean 
way of knowing if credentials were manually set by the user or not (some could 
override the credentials to `absent()` to force the authentication using the 
SSH agent).

Given this, I think it is better to fix the copy issue in the `copyTo` method. 
I will run some live tests against several providers to make sure this change 
does not break existing tests. Can you run the Azure tests with this change?


You can view, comment on, or merge this pull request online at:

  https://github.com/jclouds/jclouds/pull/724

-- Commit Summary --

  * Properly clone the login credentials

-- File Changes --

    M compute/src/main/java/org/jclouds/compute/options/TemplateOptions.java 
(19)

-- Patch Links --

https://github.com/jclouds/jclouds/pull/724.patch
https://github.com/jclouds/jclouds/pull/724.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/724

Reply via email to