>      * @see 
> org.jclouds.googlecomputeengine.features.FirewallApi#patch(String, 
> org.jclouds.googlecomputeengine.options.FirewallOptions)
>      */
> -   private void getOrCreateFirewalls(GoogleComputeEngineTemplateOptions 
> templateOptions, Network network,
> -                                     FirewallTagNamingConvention naming) {
> -
> +   private void 
> getAndUpdateOrCreateFirewalls(GoogleComputeEngineTemplateOptions 
> templateOptions, Network network,
> +                                             String sharedResourceName) {
> +      String firewallName = 
> templateOptions.getNetworkName().or(sharedResourceName);

Ping. Seeing jclouds-labs-google was not promoted to core if we want to make 
these kinds of changes now is the time to do it. 

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/20/files#r28215641

Reply via email to