> +/**
> + * Tests parsing and Guice wiring of StackApi
> + */
> +@Test(groups = "live", testName = "StackApiLiveTest")
> +public class StackApiLiveTest extends BaseHeatApiLiveTest {
> +
> +   public static final String TEMPLATE_URL = 
> "http://10.5.5.121/Installs/cPaaS/YAML/simple_stack.yaml";;
> +   protected String stackName = System.getProperty("user.name").replace('.', 
> '-').toLowerCase();
> +
> +   public void testList() {
> +      for (String region : api.getConfiguredRegions()) {
> +         StackApi stackApi = api.getStackApi(region);
> +
> +         List<Stack> stacks = stackApi.list();
> +
> +         assertThat(stacks).isNotNull();

Is this enough to guarantee that the call works? Shouldn't we better check if 
it is empty, or setup the test in a way that it returns a non-empty list, so we 
can assert that everything (including deserialization) works?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/188/files#r28424589

Reply via email to