New generation hardware instance types prefer HVM, with some not supporting Paravirtual. The code used to assume all AWS Hardware instance types were PV, causing the failure described at https://issues.apache.org/jira/browse/JCLOUDS-889 .
This also adds a `boolean deprecated` to `Hardware`, defaulting to `false`, with `TemplateBuilderImpl` preferring non-deprecated hardware types. For AWS types, we deprecate those "previous generation" hardware instance types which AWS says should only be used where an image has been specially optimized for the type. This means new-generation instance types will be preferred. You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds/pull/732 -- Commit Summary -- * indicate virtualization type for all ec2 instance types * add deprecated flag to Hardware and prefer non-deprecated hardware types -- File Changes -- M apis/ec2/src/main/java/org/jclouds/ec2/compute/domain/EC2HardwareBuilder.java (234) M apis/ec2/src/main/java/org/jclouds/ec2/compute/functions/ImagesToRegionAndIdMap.java (9) M apis/ec2/src/test/java/org/jclouds/ec2/compute/EC2TemplateBuilderTest.java (46) M apis/ec2/src/test/java/org/jclouds/ec2/compute/internal/EC2TemplateBuilderImplTest.java (52) M compute/src/main/java/org/jclouds/compute/domain/Hardware.java (5) M compute/src/main/java/org/jclouds/compute/domain/HardwareBuilder.java (12) M compute/src/main/java/org/jclouds/compute/domain/internal/HardwareImpl.java (12) M compute/src/main/java/org/jclouds/compute/domain/internal/TemplateBuilderImpl.java (7) M compute/src/test/java/org/jclouds/compute/domain/internal/TemplateBuilderImplTest.java (58) -- Patch Links -- https://github.com/jclouds/jclouds/pull/732.patch https://github.com/jclouds/jclouds/pull/732.diff --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/732
