This is a WIP branch. 

This branch changes the compute abstraction to use the default network when 
creating nodes in a group. A user can still create nodes in a different network 
by creating a network and then passing in the URI through 
`GoogleComputeEngineTemplateOptions`.

Node deletion and clean up makes no attempt to delete networks. This change 
encourages users to use the default network. If users want to use a different 
network then they are in charge of creating and destroying the network.

This PR also addresses the issue of creating one firewall rule per inbound 
port. 

There is still work to be done. 
WDYT?
You can view, comment on, or merge this pull request online at:

  https://github.com/jclouds/jclouds-labs-google/pull/138

-- Commit Summary --

  * stashing changes, now uses default network
  * removing network management

-- File Changes --

    M 
google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/compute/GoogleComputeEngineService.java
 (36)
    M 
google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/compute/GoogleComputeEngineServiceAdapter.java
 (13)
    M 
google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/compute/config/GoogleComputeEngineServiceContextModule.java
 (18)
    D 
google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/compute/functions/CreateNetworkIfNeeded.java
 (74)
    D 
google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/compute/functions/FindNetworkOrCreate.java
 (45)
    M 
google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/compute/functions/FirewallTagNamingConvention.java
 (14)
    M 
google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/compute/functions/InstanceToNodeMetadata.java
 (1)
    M 
google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/compute/strategy/CreateNodesWithGroupEncodedIntoNameThenAddToSet.java
 (107)
    M 
google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/compute/GoogleComputeEngineServiceMockTest.java
 (51)
    D 
google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/compute/functions/CreateNetworkIfNeededTest.java
 (130)
    D 
google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/compute/functions/FindNetworkOrCreateTest.java
 (130)
    A 
google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/SimplifyPortsTest.java
 (54)
    M 
google-compute-engine/src/test/resources/GoogleComputeEngineServiceExpectTest/firewall_list.json
 (3)
    M google-compute-engine/src/test/resources/firewall_insert_2.json (4)
    M google-compute-engine/src/test/resources/instance_insert_2.json (2)

-- Patch Links --

https://github.com/jclouds/jclouds-labs-google/pull/138.patch
https://github.com/jclouds/jclouds-labs-google/pull/138.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/138

Reply via email to