>        }
>  
> -      for (AtomicReference<Operation> operation : operations) {
> +      List<String> ports = simplifyPorts(inboundPorts);
> +      String name = naming.name(ports);
> +      Firewall firewall = firewallApi.get(name);
> +      AtomicReference<Operation> operation = null;
> +      if (firewall == null){

If firewall is not null then the specific firewall we are about to create 
already exists. We are appending a hash to the end of the firewall name to both 
make the name unique and indicate which ports it opens to tcp and udp. If a 
firewall with the name already exists then we assume it opens the correct ports 
and has the correct tag. 

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/138/files#r29568413

Reply via email to