@devcsrj I've seen a couple of things that are not OK in the Provisioning 
manager. I've done some minor changes and fixed some stuff, but haven't tried 
running the live tests. You can see the diff here: 
https://github.com/nacx/jclouds-labs/compare/199a90fd53526c8a6e7803ea51be157da77154c3...profitbricks

Things I've found:

* Using the `putIfAbsent` to put a new ExecutorService to the map, could leak 
executor services when the value was absent. They were created but not added.
* Once the manager was closed, one could still enqueue jobs, as the executors 
are created on demand.
* I've also changed the manager to be properly typed, but I'm not 100% sure 
that will be guice friendly :) Just discard that part if it does not work.

Could you try running the live tests with my changes?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/145#issuecomment-112718397

Reply via email to