Yes, it does.

To make sure everything is closed when closing the context, a nice approach 
would be to make the SSH clients also implement `Closeable` and let the close 
method call the disconnect one. This would allow us to modify the `create` 
method in the ssh client factory to register the ssh client in the jclouds 
[Closer](https://github.com/jclouds/jclouds/blob/master/core/src/main/java/org/jclouds/lifecycle/Closer.java),
 just the same way it is done [with the 
executors](https://github.com/jclouds/jclouds/blob/master/core/src/main/java/org/jclouds/concurrent/config/ExecutorServiceModule.java#L136).

That closer object is invoked when the context is closed, to make sure all 
resources bound to the context are properly closed. Registering the ssh clients 
there, to make sure everything is properly released even when the user has not 
explicitly called disconnect seems like a good idea. WDYT?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/778#issuecomment-117341890

Reply via email to