>From the 1.19 API docs I see that the `Devices` field in the create cointainer 
>JSON is _A list of devices to add to the container specified as a JSON object_ 
>and looks like the following array:

    [ {
        "PathOnHost": "/dev/deviceName",
        "PathInContainer": "/dev/deviceName",
        "CgroupPermissions": "mrw"
    }, { ... } ]

So, to support this we would need to make another DTO with these device fields. 
Looking at the next few lines of these docs there are several other 
configuration properties not supported by our driver, such as `Ulimits`nand 
`LogConfig`, so it is not alone. We should leave the `Devices` field as `null` 
in this PR, but if people feel strongly about supporting it then another PR 
should be created to do this, and we can explore the other gaps in the API 
coverage at the same time.

I agree with @csabapalfi that there is an existing workaround using the 
`--privileged` flag that people are using, which we can support via setting the 
`privileged` field in the DTO, so I'm happy with the way things are here.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/188#issuecomment-121966349

Reply via email to