@nacx on your comments:

1.) All comments should be addressed. And you're right about the DELETE method, 
no request I could find uses a body when issuing a delete. All tests proved 
successful so it looks like we are good on that end.

2.) Comments have been addressed.

3.) I've added one more request to the MiscellaneousApi: metrics. Documentation 
on it can be found here: 
https://github.com/coreos/etcd/blob/master/Documentation/metrics.md. It's 
experimental at this point, so far as features/structure, but works as expected 
and returns the expected output. It's the last endpoint I want to get in before 
closing this PR and I think is a good reason to keep this as a separate class 
rather than merging with EtcdApi class. I'm not sure if the name 
'Miscellaneous' fits but it's what I came up with to put all requests coming 
from the root URL in one place. Moving these into the EtcdApi seems it may 
clutter things IMO and I know there are commits for the next version to add at 
least 1 more endpoint to the root URL. If we can I'd like to leave them 
separated if only to make things easier to digest. The name is not great but 
I'm open to suggestions. 

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/195#issuecomment-126340849

Reply via email to