This is a straightforward replace of assert x -> assertThat(x).isTrue()
It doesn't specialize cases like: assert x == null -> assertThat(x).isNull() You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds/pull/849 -- Commit Summary -- * replace old style asserts with AssertJ's assertThat -- File Changes -- M apis/atmos/src/test/java/org/jclouds/atmos/AtmosClientLiveTest.java (35) M apis/atmos/src/test/java/org/jclouds/atmos/blobstore/integration/AtmosIntegrationLiveTest.java (13) M apis/atmos/src/test/java/org/jclouds/atmos/options/ListOptionsTest.java (7) M apis/byon/src/test/java/org/jclouds/byon/BYONComputeServiceLiveTest.java (5) M apis/chef/src/test/java/org/jclouds/chef/handlers/ChefApiErrorRetryHandlerTest.java (7) M apis/cloudstack/src/test/java/org/jclouds/cloudstack/compute/CloudStackComputeServiceAdapterLiveTest.java (5) M apis/cloudstack/src/test/java/org/jclouds/cloudstack/compute/CloudStackExperimentLiveTest.java (5) M apis/cloudstack/src/test/java/org/jclouds/cloudstack/features/AccountApiLiveTest.java (73) M apis/cloudstack/src/test/java/org/jclouds/cloudstack/features/AddressApiLiveTest.java (17) M apis/cloudstack/src/test/java/org/jclouds/cloudstack/features/AsyncJobApiLiveTest.java (21) M apis/cloudstack/src/test/java/org/jclouds/cloudstack/features/ConfigurationApiLiveTest.java (6) M apis/cloudstack/src/test/java/org/jclouds/cloudstack/features/DomainUserApiLiveTest.java (11) M apis/cloudstack/src/test/java/org/jclouds/cloudstack/features/EventApiLiveTest.java (25) M apis/cloudstack/src/test/java/org/jclouds/cloudstack/features/FirewallApiLiveTest.java (41) M apis/cloudstack/src/test/java/org/jclouds/cloudstack/features/GlobalAlertApiLiveTest.java (3) M apis/cloudstack/src/test/java/org/jclouds/cloudstack/features/GlobalConfigurationApiLiveTest.java (13) M apis/cloudstack/src/test/java/org/jclouds/cloudstack/features/GlobalHostApiLiveTest.java (17) M apis/cloudstack/src/test/java/org/jclouds/cloudstack/features/GlobalPodApiLiveTest.java (3) M apis/cloudstack/src/test/java/org/jclouds/cloudstack/features/GlobalUserApiLiveTest.java (3) M apis/cloudstack/src/test/java/org/jclouds/cloudstack/features/GlobalVlanApiLiveTest.java (3) M apis/cloudstack/src/test/java/org/jclouds/cloudstack/features/GuestOSApiLiveTest.java (15) M apis/cloudstack/src/test/java/org/jclouds/cloudstack/features/HypervisorApiLiveTest.java (5) M apis/cloudstack/src/test/java/org/jclouds/cloudstack/features/LimitApiLiveTest.java (8) M apis/cloudstack/src/test/java/org/jclouds/cloudstack/features/LoadBalancerApiLiveTest.java (25) M apis/cloudstack/src/test/java/org/jclouds/cloudstack/features/NATApiLiveTest.java (21) M apis/cloudstack/src/test/java/org/jclouds/cloudstack/features/NetworkApiLiveTest.java (55) M apis/cloudstack/src/test/java/org/jclouds/cloudstack/features/OfferingApiLiveTest.java (47) M apis/cloudstack/src/test/java/org/jclouds/cloudstack/features/SSHKeyPairApiLiveTest.java (3) M apis/cloudstack/src/test/java/org/jclouds/cloudstack/features/SecurityGroupApiLiveTest.java (49) M apis/cloudstack/src/test/java/org/jclouds/cloudstack/features/TemplateApiLiveTest.java (39) M apis/cloudstack/src/test/java/org/jclouds/cloudstack/features/VirtualMachineApiLiveTest.java (83) M apis/cloudstack/src/test/java/org/jclouds/cloudstack/features/ZoneApiLiveTest.java (21) M apis/cloudstack/src/test/java/org/jclouds/cloudstack/predicates/NetworkPredicatesTest.java (29) M apis/cloudstack/src/test/java/org/jclouds/cloudstack/predicates/PublicIPAddressPredicatesTest.java (11) M apis/ec2/src/test/java/org/jclouds/ec2/CloudApplicationArchitecturesEC2ApiLiveTest.java (19) M apis/ec2/src/test/java/org/jclouds/ec2/EBSBootEC2ApiLiveTest.java (17) M apis/ec2/src/test/java/org/jclouds/ec2/compute/EC2ComputeServiceLiveTest.java (9) M apis/ec2/src/test/java/org/jclouds/ec2/compute/EC2TemplateBuilderLiveTest.java (5) M apis/ec2/src/test/java/org/jclouds/ec2/compute/EC2TemplateBuilderTest.java (21) M apis/ec2/src/test/java/org/jclouds/ec2/compute/functions/RunningInstanceToNodeMetadataTest.java (3) M apis/ec2/src/test/java/org/jclouds/ec2/compute/options/EC2TemplateOptionsTest.java (7) M apis/ec2/src/test/java/org/jclouds/ec2/features/AMIApiLiveTest.java (3) M apis/ec2/src/test/java/org/jclouds/ec2/features/AvailabilityZoneAndRegionApiLiveTest.java (5) M apis/ec2/src/test/java/org/jclouds/ec2/features/ElasticBlockStoreApiLiveTest.java (11) M apis/ec2/src/test/java/org/jclouds/ec2/features/SecurityGroupApiLiveTest.java (5) M apis/ec2/src/test/java/org/jclouds/ec2/options/BundleInstanceS3StorageOptionsTest.java (5) M apis/ec2/src/test/java/org/jclouds/ec2/options/CreateImageOptionsTest.java (5) M apis/ec2/src/test/java/org/jclouds/ec2/options/CreateSnapshotOptionsTest.java (5) M apis/ec2/src/test/java/org/jclouds/ec2/options/CreateVolumeOptionsTest.java (5) M apis/ec2/src/test/java/org/jclouds/ec2/options/DescribeImagesOptionsTest.java (5) M apis/ec2/src/test/java/org/jclouds/ec2/options/DescribeSnapshotsOptionsTest.java (5) M apis/ec2/src/test/java/org/jclouds/ec2/options/DetachVolumeOptionsTest.java (5) M apis/ec2/src/test/java/org/jclouds/ec2/options/RegisterImageBackedByEbsOptionsTest.java (5) M apis/ec2/src/test/java/org/jclouds/ec2/options/RegisterImageOptionsTest.java (5) M apis/ec2/src/test/java/org/jclouds/ec2/options/RunInstancesOptionsTest.java (5) M apis/ec2/src/test/java/org/jclouds/ec2/xml/BaseEC2HandlerTest.java (4) M apis/ec2/src/test/java/org/jclouds/ec2/xml/DescribeAvailabilityZonesResponseHandlerTest.java (3) M apis/ec2/src/test/java/org/jclouds/ec2/xml/DescribeInstanceAttributeTest.java (3) M apis/ec2/src/test/java/org/jclouds/ec2/xml/DescribeInstancesResponseHandlerTest.java (3) M apis/ec2/src/test/java/org/jclouds/ec2/xml/DescribeRegionsResponseHandlerTest.java (3) M apis/ec2/src/test/java/org/jclouds/ec2/xml/InstanceStateChangeHandlerTest.java (3) M apis/ec2/src/test/java/org/jclouds/ec2/xml/KeyPairResponseHandlerTest.java (5) M apis/ec2/src/test/java/org/jclouds/ec2/xml/RunInstancesResponseHandlerTest.java (3) M apis/elasticstack/src/test/java/org/jclouds/elasticstack/ElasticStackApiLiveTest.java (21) M apis/elasticstack/src/test/java/org/jclouds/elasticstack/compute/ElasticStackComputeServiceLiveTest.java (4) M apis/openstack-keystone/src/test/java/org/jclouds/openstack/v2_0/predicates/ExtensionPredicatesTest.java (13) M apis/openstack-keystone/src/test/java/org/jclouds/openstack/v2_0/predicates/LinkPredicatesTest.java (13) M apis/openstack-nova-ec2/src/test/java/org/jclouds/openstack/nova/ec2/compute/NovaEC2ComputeServiceLiveTest.java (4) M apis/openstack-nova/src/test/java/org/jclouds/openstack/nova/v2_0/compute/options/NovaTemplateOptionsTest.java (13) M apis/openstack-nova/src/test/java/org/jclouds/openstack/nova/v2_0/extensions/FloatingIPApiLiveTest.java (3) M apis/openstack-nova/src/test/java/org/jclouds/openstack/nova/v2_0/predicates/ImagePredicatesTest.java (5) M apis/openstack-swift/src/test/java/org/jclouds/openstack/swift/v1/blobstore/integration/SwiftBlobIntegrationLiveTest.java (5) M apis/rackspace-cloudloadbalancers/src/test/java/org/jclouds/rackspace/cloudloadbalancers/v1/features/LoadBalancerApiLiveTest.java (23) M apis/rackspace-cloudloadbalancers/src/test/java/org/jclouds/rackspace/cloudloadbalancers/v1/features/NodeApiLiveTest.java (17) M apis/route53/src/test/java/org/jclouds/route53/predicates/HostedZonePredicatesTest.java (5) M apis/route53/src/test/java/org/jclouds/route53/predicates/ResourceRecordSetPredicatesTest.java (5) M apis/s3/src/test/java/org/jclouds/s3/PathBasedS3ClientExpectTest.java (7) M apis/s3/src/test/java/org/jclouds/s3/S3ClientExpectTest.java (5) M apis/s3/src/test/java/org/jclouds/s3/S3ClientLiveTest.java (20) M apis/s3/src/test/java/org/jclouds/s3/filters/RequestAuthorizeSignatureTest.java (5) M apis/s3/src/test/java/org/jclouds/s3/options/CopyObjectOptionsTest.java (7) M apis/s3/src/test/java/org/jclouds/s3/options/ListBucketOptionsTest.java (5) M apis/s3/src/test/java/org/jclouds/s3/services/BucketsLiveTest.java (17) M apis/s3/src/test/java/org/jclouds/s3/xml/CopyObjectHandlerTest.java (3) M apis/s3/src/test/java/org/jclouds/s3/xml/ListBucketHandlerTest.java (5) M apis/s3/src/test/java/org/jclouds/s3/xml/S3ParserTest.java (39) M apis/sqs/src/test/java/org/jclouds/sqs/internal/BaseSQSApiLiveTest.java (3) M apis/sqs/src/test/java/org/jclouds/sqs/options/ListQueuesOptionsTest.java (5) M apis/sts/src/test/java/org/jclouds/aws/handlers/AWSClientErrorRetryHandlerTest.java (5) M apis/sts/src/test/java/org/jclouds/aws/handlers/AWSServerErrorRetryHandlerTest.java (3) M apis/swift/src/test/java/org/jclouds/openstack/swift/CommonSwiftClientLiveTest.java (19) M apis/swift/src/test/java/org/jclouds/openstack/swift/blobstore/integration/SwiftBlobIntegrationLiveTest.java (5) M apis/swift/src/test/java/org/jclouds/openstack/swift/options/ListContainerOptionsTest.java (5) M blobstore/src/test/java/org/jclouds/blobstore/integration/internal/BaseBlobIntegrationTest.java (44) M blobstore/src/test/java/org/jclouds/blobstore/integration/internal/BaseBlobSignerLiveTest.java (3) M blobstore/src/test/java/org/jclouds/blobstore/integration/internal/BaseBlobStoreIntegrationTest.java (35) M blobstore/src/test/java/org/jclouds/blobstore/integration/internal/BaseContainerIntegrationTest.java (68) M blobstore/src/test/java/org/jclouds/blobstore/integration/internal/BaseServiceIntegrationTest.java (25) M common/openstack/src/test/java/org/jclouds/openstack/predicates/LinkPredicatesTest.java (13) M compute/src/test/java/org/jclouds/compute/ComputeTestUtils.java (5) M compute/src/test/java/org/jclouds/compute/callables/InitScriptConfigurationForTasksTest.java (7) M compute/src/test/java/org/jclouds/compute/domain/internal/TemplateBuilderImplTest.java (3) M compute/src/test/java/org/jclouds/compute/internal/BaseComputeServiceLiveTest.java (121) M compute/src/test/java/org/jclouds/compute/internal/BaseTemplateBuilderLiveTest.java (31) M compute/src/test/java/org/jclouds/compute/predicates/HardwarePredicatesTest.java (6) M compute/src/test/java/org/jclouds/compute/predicates/ImagePredicatesTest.java (10) M compute/src/test/java/org/jclouds/compute/predicates/OperatingSystemPredicatesTest.java (65) M compute/src/test/java/org/jclouds/ssh/SshKeysTest.java (19) M core/src/test/java/org/jclouds/ContextBuilderTest.java (9) M core/src/test/java/org/jclouds/apis/internal/BaseApiMetadataTest.java (7) M core/src/test/java/org/jclouds/domain/JsonBallTest.java (19) M core/src/test/java/org/jclouds/http/BaseJettyTest.java (5) M core/src/test/java/org/jclouds/http/HttpRequestTest.java (3) M core/src/test/java/org/jclouds/http/functions/BaseHandlerTest.java (3) M core/src/test/java/org/jclouds/http/functions/ParseURIFromListOrLocationHeaderIf20xTest.java (5) M core/src/test/java/org/jclouds/http/functions/ReturnStringIf200Test.java (5) M core/src/test/java/org/jclouds/http/handlers/BackoffLimitedRetryHandlerTest.java (17) M core/src/test/java/org/jclouds/http/handlers/RedirectionRetryHandlerTest.java (7) M core/src/test/java/org/jclouds/http/utils/QueriesTest.java (17) M core/src/test/java/org/jclouds/io/payloads/MultipartFormTest.java (3) M core/src/test/java/org/jclouds/lifecycle/config/LifeCycleModuleTest.java (39) M core/src/test/java/org/jclouds/logging/config/BindLoggersAnnotatedWithResourceTest.java (7) M core/src/test/java/org/jclouds/providers/internal/BaseProviderMetadataTest.java (11) M core/src/test/java/org/jclouds/rest/internal/BaseHttpApiMetadataTest.java (3) M core/src/test/java/org/jclouds/rest/internal/BaseRestApiTest.java (3) M core/src/test/java/org/jclouds/rest/internal/RestAnnotationProcessorTest.java (5) M core/src/test/java/org/jclouds/util/InetAddresses2Test.java (16) M core/src/test/java/org/jclouds/util/Strings2Test.java (15) M drivers/bouncycastle/src/test/java/org/jclouds/encryption/bouncycastle/BouncyCastleCryptoTest.java (4) M drivers/gae/src/test/java/org/jclouds/gae/ConvertToGaeRequestTest.java (5) M drivers/joda/src/test/java/org/jclouds/date/joda/JodaDateServiceTest.java (3) M drivers/jsch/src/test/java/org/jclouds/ssh/jsch/JschSshClientLiveTest.java (3) M drivers/jsch/src/test/java/org/jclouds/ssh/jsch/JschSshClientTest.java (47) M drivers/jsch/src/test/java/org/jclouds/ssh/jsch/config/JschSshClientModuleTest.java (4) M drivers/sshj/src/test/java/org/jclouds/sshj/SshjSshClientLiveTest.java (3) M drivers/sshj/src/test/java/org/jclouds/sshj/SshjSshClientTest.java (49) M drivers/sshj/src/test/java/org/jclouds/sshj/config/SshjSshClientModuleTest.java (4) M providers/aws-ec2/src/test/java/org/jclouds/aws/ec2/compute/AWSEC2ComputeServiceLiveTest.java (21) M providers/aws-ec2/src/test/java/org/jclouds/aws/ec2/compute/AWSEC2TemplateBuilderLiveTest.java (47) M providers/aws-ec2/src/test/java/org/jclouds/aws/ec2/compute/functions/AWSRunningInstanceToNodeMetadataTest.java (3) M providers/aws-ec2/src/test/java/org/jclouds/aws/ec2/compute/options/AWSEC2TemplateOptionsTest.java (13) M providers/aws-ec2/src/test/java/org/jclouds/aws/ec2/features/AWSAMIApiLiveTest.java (5) M providers/aws-ec2/src/test/java/org/jclouds/aws/ec2/features/AWSInstanceApiLiveTest.java (3) M providers/aws-ec2/src/test/java/org/jclouds/aws/ec2/features/AWSKeyPairApiLiveTest.java (7) M providers/aws-ec2/src/test/java/org/jclouds/aws/ec2/features/PlacementGroupApiLiveTest.java (9) M providers/aws-ec2/src/test/java/org/jclouds/aws/ec2/features/SpotInstanceApiLiveTest.java (18) M providers/aws-ec2/src/test/java/org/jclouds/aws/ec2/options/AWSDescribeImagesOptionsTest.java (5) M providers/aws-ec2/src/test/java/org/jclouds/aws/ec2/options/AWSRunInstancesOptionsTest.java (5) M providers/aws-ec2/src/test/java/org/jclouds/aws/ec2/options/DescribeSpotPriceHistoryOptionsTest.java (5) M providers/aws-ec2/src/test/java/org/jclouds/aws/ec2/options/RequestSpotInstancesOptionsTest.java (5) M providers/aws-ec2/src/test/java/org/jclouds/aws/ec2/parse/DescribeInstancesResponseTest.java (3) M providers/aws-ec2/src/test/java/org/jclouds/aws/ec2/xml/AWSDescribeInstancesResponseHandlerTest.java (3) M providers/aws-ec2/src/test/java/org/jclouds/aws/ec2/xml/AWSRunInstancesResponseHandlerTest.java (3) M providers/aws-ec2/src/test/java/org/jclouds/aws/ec2/xml/SpotInstanceHandlerTest.java (3) M providers/aws-ec2/src/test/java/org/jclouds/aws/ec2/xml/SpotInstancesHandlerTest.java (3) M providers/aws-s3/src/test/java/org/jclouds/aws/s3/services/AWSBucketsLiveTest.java (3) M providers/azureblob/src/test/java/org/jclouds/azureblob/AzureBlobClientLiveTest.java (12) M providers/azureblob/src/test/java/org/jclouds/azureblob/xml/AccountNameEnumerationResultsHandlerTest.java (3) M providers/azureblob/src/test/java/org/jclouds/azureblob/xml/ContainerNameEnumerationResultsHandlerTest.java (3) M providers/dynect/src/test/java/org/jclouds/dynect/v3/predicates/RecordPredicatesTest.java (5) M providers/glesys/src/test/java/org/jclouds/glesys/GleSYSApiTest.java (10) M providers/glesys/src/test/java/org/jclouds/glesys/features/ServerApiLiveTest.java (35) M providers/gogrid/src/test/java/org/jclouds/gogrid/GoGridApiTest.java (12) M providers/gogrid/src/test/java/org/jclouds/gogrid/GoGridLiveTestDisabled.java (51) M providers/gogrid/src/test/java/org/jclouds/gogrid/compute/GoGridComputeServiceLiveTest.java (7) M providers/gogrid/src/test/java/org/jclouds/gogrid/compute/config/GoGridComputeServiceContextModuleTest.java (4) M providers/gogrid/src/test/java/org/jclouds/gogrid/features/GridImageApiLiveTest.java (31) M providers/gogrid/src/test/java/org/jclouds/gogrid/features/GridJobApiLiveTest.java (27) M providers/gogrid/src/test/java/org/jclouds/gogrid/options/AddServerOptionsTest.java (5) M providers/gogrid/src/test/java/org/jclouds/gogrid/options/SaveImageOptionsTest.java (5) M providers/google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/compute/GoogleComputeEngineServiceLiveTest.java (3) M providers/hpcloud-objectstorage/src/test/java/org/jclouds/hpcloud/objectstorage/HPCloudObjectStorageClientLiveTest.java (7) M providers/hpcloud-objectstorage/src/test/java/org/jclouds/hpcloud/objectstorage/blobstore/integration/HPCloudObjectStorageBlobIntegrationLiveTest.java (10) M providers/softlayer/src/test/java/org/jclouds/softlayer/compute/SoftLayerComputeServiceAdapterLiveTest.java (3) M providers/softlayer/src/test/java/org/jclouds/softlayer/compute/SoftLayerComputeServiceLiveTest.java (6) M scriptbuilder/src/test/java/org/jclouds/scriptbuilder/statements/login/ReplaceShadowPasswordEntryOfLoginUserTest.java (7) M scriptbuilder/src/test/java/org/jclouds/scriptbuilder/statements/login/ReplaceShadowPasswordEntryTest.java (7) M scriptbuilder/src/test/java/org/jclouds/scriptbuilder/statements/login/UserAddTest.java (5) M skeletons/standalone-compute/src/test/java/org/jclouds/servermanager/compute/ServerManagerComputeServiceLiveTest.java (5) -- Patch Links -- https://github.com/jclouds/jclouds/pull/849.patch https://github.com/jclouds/jclouds/pull/849.diff --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/849
