Hi @mirza-spc ! Jumping in while this is in wait for further review. 

About the direct use of Gson in the 
[RequestBinder](https://github.com/jclouds/jclouds-labs/pull/227/files#diff-5f15aace37e6097c7e68751cd0aae853R45):
 I was looking at other JSON-returning APIs from other providers, I noticed 
that the common pattern was to inject 
[`Json`](https://github.com/jclouds/jclouds/blob/master/core/src/main/java/org/jclouds/json/Json.java),
 and use that to do the conversion. Here's an example from 
[docker](https://github.com/jclouds/jclouds-labs/blob/master/docker/src/main/java/org/jclouds/docker/features/ContainerApi.java#L80)
 which directly uses 
[`BindToJsonPayload`](https://github.com/jclouds/jclouds/blob/master/core/src/main/java/org/jclouds/rest/binders/BindToJsonPayload.java#L32),
 and for DigitalOcean2's 
[createDroplet](https://github.com/jclouds/jclouds/blob/master/providers/digitalocean2/src/main/java/org/jclouds/digitalocean2/features/DropletApi.java#L284),
 with a custom 
[binder](https://github.com/jclouds/jclouds/blob/master/providers/digitalocean2/s
 
rc/main/java/org/jclouds/digitalocean2/domain/options/CreateDropletOptions.java#L38).

Also, don't squash the commits yet! Address succeeding comments, with a 
separate commit on top of now 
[`6b2da43`](https://github.com/StackPointCloud/jclouds-labs/commit/6b2da43b2d343bbb9c123cdc2538a0bf6fb5a8e6).
 This way, it's easier for reviewers to see the changes only of the addressing 
commit. :)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/227#issuecomment-176511719

Reply via email to