> +   
> +   @Test
> +   public void testThroughSystemProxy() throws URISyntaxException {
> +      ProxyConfig config = new MyProxyConfig(true, false, Proxy.Type.HTTP, 
> noHostAndPort, noCreds);
> +      URI uri = new URI("http://example.com/file";);
> +      // could return a proxy, could return NO_PROXY, depends on the 
> tester's environment
> +      assertNotNull(new ProxyForURI(config).apply(uri));
> +   }
> +
> +   @Test
> +   public void testJvmProxyAlwaysPreferredOverSystem() throws 
> URISyntaxException {
> +      ProxyConfig test = new MyProxyConfig(true, true, Proxy.Type.HTTP, 
> noHostAndPort, noCreds);
> +      ProxyConfig jvm = new MyProxyConfig(false, true, Proxy.Type.HTTP, 
> noHostAndPort, noCreds);
> +      URI uri = new URI("http://example.com/file";);
> +      assertEquals(new ProxyForURI(test).apply(uri), new 
> ProxyForURI(jvm).apply(uri));
> +   }

Add a test that uses jvmProxy | systemProxy and also sets the jclouds proxy 
host? Just to verify that the jclouds proxy takes precedence.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/914/files#r52032139

Reply via email to