Hi @mirza-spc !

Did initial review for the PR, while waiting for others to jump in. :) In 
addition to the comments above, could you add a test for 
[`ParseId`](https://github.com/StackPointCloud/jclouds-labs/commit/60869d038e8022165b6b1c32cb80233cee213033#diff-640a66e9fc832b6c994d936877e933caR29)?
 This way, we're confident that the `#parseId` method actually returns what we 
expect. And, can you move the 
[`Pattern.compile(..)`](https://github.com/StackPointCloud/jclouds-labs/commit/60869d038e8022165b6b1c32cb80233cee213033#diff-640a66e9fc832b6c994d936877e933caR43)
 as a class level 
[property](https://github.com/StackPointCloud/jclouds-labs/commit/60869d038e8022165b6b1c32cb80233cee213033#diff-640a66e9fc832b6c994d936877e933caR32),
 so that the pattern is only compiled once (and not everytime the method is 
called).

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/233#issuecomment-182681138

Reply via email to