> +                    + cloneTemplate.getName());
> +         }
> +      });
> +   }
> +
> +   @Override
> +   public boolean deleteImage(String id) {
> +      Snapshot snapshot = api.snapshotApi().getSnapshot(id);
> +      if (snapshot != null)
> +         try {
> +            logger.debug(">> deleting snapshot %s..", id);
> +            return api.snapshotApi().deleteSnapshot(id);
> +         } catch (Exception ex) {
> +            logger.error(ex, ">> error deleting snapshot %s..", id);
> +         }
> +      return true;

Should this better be a `return false`, to cover the case when an official 
Image is provided and also cover the return value with the `catch` block is 
executed?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/929/files#r54725804

Reply via email to