Hi @ritazh, This is a fantastic job! The PR looks really good, especially when it is the first PR for the provider.
> What is the best approach for OAuth extensions? Derive and keep the new > classes within azurecompute-arm or plan a cleaned up implementation targeting > a PR into jclouds core? I'd say split the code and open a PR with the OAuth bits to the jclouds main repo. LEt's better keep all OAuth flows in the OAuth api. And one last comment given the README: can live tests be run all at once, without passing individual test names? Great job @ritazh! --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/250#issuecomment-202430296
