> this.id = checkNotNull(id, "id"); > this.name = checkNotNull(name, "name"); > this.created = Optional.fromNullable(created); > this.updated = Optional.fromNullable(updated); > - this.extraSpecs = ImmutableMap.copyOf(checkNotNull(extraSpecs, > "extraSpecs")); > + this.extraSpecs = extraSpecs == null ? new HashMap<String, String>() : > ImmutableMap.copyOf(extraSpecs);
We want immutable collections, so better use: ```java this.extraSpecs = extraSpecs == null ? ImmutableMap.of() : ImmutableMap.copyOf(extraSpecs); ``` --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/942/files/18950a9edf818c8de412505b2a404af55970edf6#r58023540
