Merged to master as 
[a4334d46](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/a4334d46).
 Fantastic job @ritazh!

I've been able to follow the steps in the README and all live tests passed.

Some notes for the upcoming pull requests:

* The TenantId is required, but in the README there is no mention to how to get 
it, and the commands in there don't print it in any output. We should provide 
that info too (I went to the classic portal and just extracted it from the 
OAuth endpoints).
* It would be nice to have instructions on how to register the app from the web 
portal. I went nuts trying to find it in the new portal until I read that the 
AD stuff is not yet available there ^^. I also tried to follow [this 
guide](https://azure.microsoft.com/en-us/documentation/articles/resource-group-create-service-principal-portal/)
 but the permission steps in the README didn't have an obvious mapping, so I 
just downloaded the CLI and used it. This is not a requirement, but it would be 
a nice to have in the jclouds site docs.
* Preconfigure the `test.jclouds.oauth.resource` value in the pom.xml so it is 
not required to manually provide it when running the live tests (it is already 
a constant value).
* Consider preconfiguring the `test.oauth.endpoint` property the same way you 
do with the api endpoint: let the users just pass the tenant id property. But 
also consider that it is easier to copy the OAuth token endpoint from the 
portal, so perhaps it is better to just remove the 
`test.jclouds.azurecompute-arm.tenant-id` as it is not used.
* Once the jclouds OAuth API is changed, remove the OAuthScopes binding.

Excellent job! Look forward to seeing the provider move forward!

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/250#issuecomment-206542192

Reply via email to