> +    }
> +
> +    @Nullable
> +    public abstract String name();
> +
> +    @Nullable
> +    public abstract String id();
> +
> +    @Nullable
> +    public abstract String etag();
> +
> +    public abstract String location();
> +
> +    public abstract VirtualNetworkProperties properties();
> +
> +    @Nullable

Ok, apologies if I misunderstood. We should avoid nullable collections, but if 
the API requires null objects, then we'd better make nullable. This said, the 
rule of thumb should be:

* If the API requires null objects, then mark it as nullable if absent, and 
assign an immutable copy otherwise.
* If the collection is mandatory, then do not mark it as nullable and assign an 
immutable empty or copied list.

This way we keep field annotations and factory methods consistent. In this 
case, the factory method below should be changed to use `null` instead of an 
empty list?

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/262/files/1801c68f227e1f245a30c6fa6ff044e7e2634460#r61043526

Reply via email to