> }
>
> - public CloudStackTemplateOptions setupStaticNat(boolean setupStaticNat) {
> - this.setupStaticNat = setupStaticNat;
> + public CloudStackTemplateOptions userData(URL userDataUrl) throws
> IOException {
> + this.userData = Resources.toString(checkNotNull(userDataUrl,
> "userDataUrl"), Charsets.UTF_8).getBytes(Charsets.UTF_8);
Why providing this method that accepts a URL? I don't see it necessary and only
introduces issues: can we guarantee the classloader being used to load the
resource the right one to load the file? And if jclouds code is deployed in a
webapp? Where do we expect to load files from?
IMO there is no need to provide this "sugar" method. Let users read
files/resources themselves and just pass the array of bytes.
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/957/files/e808dc64d204b994b579a7a1d626da728656cc2f#r63859521
