When providing node ip in metadata jclouds was using the
ip of the docker manager which was fine for docker machine
but fails when using a swarm cluster.  This uses the ip returned
from docker.

Currently the live tests for docker pass against a machine provisioning using 
docker/docker-machine. However they fail when run against a swarm cluster.  
This is because the wrong ip address is used to test ssh access to the node.  
This change will make the tests in SshToCustomPortLiveTest.java pass.

I haven't set up a docker overlay network so I don't know if the tests in 
NetworkApiLiveTest.java pass but all other live tests pass against swarm.  
You can view, comment on, or merge this pull request online at:

  https://github.com/jclouds/jclouds-labs/pull/277

-- Commit Summary --

  * Use container host ip not manager ip

-- File Changes --

    M 
docker/src/main/java/org/jclouds/docker/compute/functions/ContainerToNodeMetadata.java
 (24)
    M docker/src/main/java/org/jclouds/docker/domain/Container.java (18)
    A docker/src/main/java/org/jclouds/docker/domain/Node.java (63)
    M 
docker/src/test/java/org/jclouds/docker/compute/functions/ContainerToNodeMetadataTest.java
 (1)
    M docker/src/test/java/org/jclouds/docker/internal/DockerTestUtils.java (3)

-- Patch Links --

https://github.com/jclouds/jclouds-labs/pull/277.patch
https://github.com/jclouds/jclouds-labs/pull/277.diff

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/277

Reply via email to