> +@QueryParams(keys = "api-version", values = "2016-03-30")
> +@RequestFilters(OAuthFilter.class)
> +@Consumes(MediaType.APPLICATION_JSON)
> +public interface NetworkSecurityGroupApi {
> +
> +   @Named("networksecuritygroup:list")
> +   @GET
> +   @SelectJson("value")
> +   @Fallback(EmptyListOnNotFoundOr404.class)
> +   List<NetworkSecurityGroup> list();
> +
> +   @Named("networksecuritygroup:delete")
> +   @Path("/{networksecuritygroupname}")
> +   @DELETE
> +   @ResponseParser(FalseOn204.class)
> +   boolean delete(@PathParam("networksecuritygroupname") String nsgName);

Since this delete is async, consider using `URIParser`, similar to 
[this](https://github.com/jclouds/jclouds-labs/blob/master/azurecompute-arm/src/main/java/org/jclouds/azurecompute/arm/features/ResourceGroupApi.java#L89-L94)

Please also test the returned uri to ensure it is not null. Also add the 
fallback test case like 
[this](https://github.com/jclouds/jclouds-labs/blob/master/azurecompute-arm/src/test/java/org/jclouds/azurecompute/arm/features/ResourceGroupApiMockTest.java#L141-L148)

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/278/files/76791340f71414d5966d0239904de9b7ab673919#r65485172

Reply via email to