[ 
https://issues.apache.org/jira/browse/JCLOUDS-1143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15384177#comment-15384177
 ] 

Stephen Tomkinson commented on JCLOUDS-1143:
--------------------------------------------

I've raised a pull request on GitHub. Any problems, please let me know.

> AWSv4SignerBase fails to log canonicalRequest
> ---------------------------------------------
>
>                 Key: JCLOUDS-1143
>                 URL: https://issues.apache.org/jira/browse/JCLOUDS-1143
>             Project: jclouds
>          Issue Type: Bug
>          Components: jclouds-blobstore
>    Affects Versions: 2.0.0
>            Reporter: Stephen Tomkinson
>            Priority: Minor
>
> The logging of the "canonical request" for AWS v4 signing of S3 requests 
> currently omits the canonical request string itself. The cause appears to be 
> line 403 
> (https://github.com/apache/jclouds/blob/18cba94fab010152f00396439c3d1a8bfd9d7681/apis/s3/src/main/java/org/jclouds/s3/filters/Aws4SignerBase.java#L403)
>  which is using a templated logging call, but passes a logging message String 
> without template placeholders.
> Elsewhere, String concatenation is used - e.g. 
> https://github.com/apache/jclouds/blob/18cba94fab010152f00396439c3d1a8bfd9d7681/apis/s3/src/main/java/org/jclouds/s3/filters/Aws4SignerForChunkedUpload.java#L191



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to