> Network network = getOrCreateNetwork(templateOptions,
> sharedResourceName);
> - getOrCreateFirewalls(templateOptions, network,
> firewallTagNamingConvention.get(group));
> + // add firewalls *only* if the template options don't contain explicit
> network
> + if (templateOptions.network() == null) {
But it is not the same case. In OpenStack you have networks, and have security
groups. By configuring the networks you are just saying to which networks a
server should be attached. By configuring explicitly the security groups, you
are telling exactly which "firewall policies" should apply to the server, so it
makes sense to let that take precedence over the "inboundPorts".
Networks and security groups are not the same thing; one configures networking
(ips, routing, etc), the other configures access (open ports, etc). It is not
OK to say that attaching a server to a network implies that jclouds would
ignore all access configuration to that server. In nova we don't do this; if
the user explicitly configured a set of security groups (not related to
networks), we use them to configure the access to the server, taking precedence
over the inbound ports option, but the important thing here is that no one is
mixing the network options and the firewall options.
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/172/files/a083442f462a4b5dcc0c9dabfcca8a181b8e2889#r73108790
