Having a closer look, the strategy that validates the firewalls will call the 
api only once for each firewall, but then the code in the adapter will be 
executed once for each firewall and node being deployed, which is too many 
redundant calls.

Given that the adapter [already sets the configured 
tags](https://github.com/jclouds/jclouds/blob/master/providers/google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/compute/GoogleComputeEngineServiceAdapter.java#L140),
 I'd change the strategy to, instead of just validating, add the tags to the 
templateOptions.tags, so the adapter always gets the list of tags to apply 
properly populated. This way we eliminate all code from the adapter that is 
coupled to the firewall naming generation and keep everything in one place (and 
we save all those redundant calls). WDYT?

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/985#issuecomment-236902350

Reply via email to