nacx approved this pull request.
> private final ProviderMetadata providerMetadata;
+ private final DeploymentToVMDeployment deploymentToVMDeployment;
Better declare and inject it as `Function<Deployment, VMDeployment>` to make it
easier to re-bind.
> @@ -288,7 +279,7 @@ public VMImage getImage(final String id) {
@Override
public Iterable<Location> listLocations() {
- final Iterable<String> whiteListZoneName = findWhiteListOfRegions();
+ final Iterable<String> whiteListedRegionNames = findWhiteListOfRegions();
You are parsing this list in several places. Just call this in the constructor
and assign to a class final variable.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/320#pullrequestreview-960424
