nacx commented on this pull request.
> @@ -234,6 +234,13 @@ public String get() {
return authenticationMethods.get(credentialType);
}
+ @Provides
+ @Singleton
+ @Named("credentialsRetryable")
+ protected final boolean credentialsRetryable(Function<Credentials, Access>
getAccess) {
Hmm... Nope, the code should call `credentialType.retryable()`, but it makes
more sense to object a CredentialType object than a boolean named "something".
The code is easier to read and understand if injecting the object (and easier
to extend in the future).
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1009
