[ https://issues.apache.org/jira/browse/JCLOUDS-1158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15571855#comment-15571855 ]
ASF subversion and git services commented on JCLOUDS-1158: ---------------------------------------------------------- Commit 26c060a0e899333bed560b1def58ac08634d12fd in jclouds's branch refs/heads/fix/AzureTemplateBuilderLiveTest from [~hendrens] [ https://git-wip-us.apache.org/repos/asf?p=jclouds.git;h=26c060a ] JCLOUDS-1185 Allow rangeIPv4 to be null The default network of recently created projects have a null value for rangeIPv4 And all regions as subnets, which do have values for the rangeIPv4. Fixes JCLOUDS-1158 > DockerComputeServiceAdapter.getImage(String) doesn't work correctly for > Docker on RHEL Atomic host > -------------------------------------------------------------------------------------------------- > > Key: JCLOUDS-1158 > URL: https://issues.apache.org/jira/browse/JCLOUDS-1158 > Project: jclouds > Issue Type: Bug > Components: jclouds-labs > Reporter: Josef Cacek > Labels: docker > Fix For: 2.0.0 > > > The > {{org.jclouds.docker.compute.strategy.DockerComputeServiceAdapter.getImage(String)}} > method doesn't find images when Docker from RHEL (Atomic) is used. The > reason is the returned Image {{repoTags}} field from the Docker server > contains also registry hostname. E.g. > {code} > "RepoTags":["docker.io/kwart/alpine-ext:3.3-ssh"] > {code} > The problem is in the condition used in this piece of code: > {code} > for (String tag : input.repoTags()) { > if (tag.equals(imageIdOrName) || tag.equals(imageIdOrName + ":latest")) { > return true; > } > } > {code} > IMO, we should add also 2 more options to statement: > {code} > final String imageNameWithHostPrefix = "docker.io/" + imageIdOrName; > for (String tag : input.repoTags()) { > if (tag.equals(imageIdOrName) || tag.equals(imageIdOrName + ":latest") > || tag.equals(imageNameWithHostPrefix) || > tag.equals(imageNameWithHostPrefix + ":latest")) { > ... > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)