nacx commented on this pull request.
> @@ -116,7 +115,11 @@ public boolean shouldRetryRequest(HttpCommand command,
> HttpResponse response) {
return retry;
} finally {
- releasePayload(response);
+ // If the request is failed and is not going to be retried, the
+ // ErrorHandler will be invoked and it might need to read the payload.
+ // For some kind of payload sources, such as the OkHttp Source, if the
+ // payload is released, the upcoming operations will fail.
+ closeClientButKeepContentStream(response);
Is the retry handler doing something with the payload? If not, I'd just remove
the finally block to avoid buffering it in memory unnecessarily.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1027#pullrequestreview-5875597
