nacx commented on this pull request.
Just a couple minors. Apart from that LGTM! Thanks @alibazlamit!
> @@ -69,30 +72,31 @@ public void testCreateServer() {
.cores(1)
.ram(1024)
.build());
-
+
+ assertRequestCompleted(testServer);
Duplicated?
> @@ -105,149 +109,166 @@ public void testUpdateServer() {
.ram(1024 * 2)
.cores(2)
.build());
-
+
+ assertRequestCompleted(updated);
Duplicated?
> attachedVolume = serverApi().attachVolume(
Server.Request.attachVolumeBuilder()
.dataCenterId(testServer.dataCenterId())
.serverId(testServer.id())
.volumeId(volume.id())
.build()
);
-
+
+ assertRequestCompleted(attachedVolume);
Same here, duplicate?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/333#pullrequestreview-6369950
