nacx commented on this pull request.
> @@ -87,7 +87,7 @@ protected ComputeService getComputeService() throws
> IOException {
String apiValue = EnvHelper.getComputeApi(api);
String identityValue = EnvHelper.getComputeIdentity(identity);
String credentialValue = EnvHelper.getComputeCredential(credential);
- if (providerValue.equals("google-compute-engine")) {
+ if (providerValue != null && credentialValue != null &&
providerValue.equals("google-compute-engine")) {
Yes, to avoid an NPE when trying to parse the json file. The helper method
expects the value not to be null.
--
You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/85
